This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Update app services, android components, and megazord configuration #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jhugman
approved these changes
Aug 12, 2019
| } else { | ||
| logger.lifecycle("Local configuration: application-services substitution path missing. Specify it via '$settingAppServicesPath' setting.") | ||
| } | ||
| } |
| @@ -9,11 +9,12 @@ | |||
| buildscript { | |||
| ext.android_support_version = '28.0.0' | |||
| ext.kotlin_version = '1.3.0' | |||
| ext.android_components_version = '4.0.0' | |||
| // XXX: might not want to use the prerelease version? | |||
| ext.android_components_version = '7.0.0-SNAPSHOT' | |||
There was a problem hiding this comment.
We should probably not release with a snapshot version of Android Components.
There was a problem hiding this comment.
7.0.0 is released now, we might like to update to that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the last A-S/Lockwise meeting, this is a PR that updates A-S/A-C to the new megazord configuration. It also includes the long-awaited telemetry ping support, however it just logs it to the console in a hacky way.
This is a PR, but as discussed, I won't have time to see this through, so someone should take it over for me. At a minimum I think: